-
Notifications
You must be signed in to change notification settings - Fork 89
Rename DateTimeFeaturization to DateTimeFeaturizer #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once all tests pass, LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsherry I think this is good to merge when all the tests pass!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass
cfa0776
to
838d54b
Compare
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 174 174
Lines 8990 8990
=======================================
Hits 8979 8979
Misses 11 11
Continue to review full report at Codecov.
|
After discussion we named the text featurizer
TextFeaturizer
because we liked that convention more thanTextFeaturization
. Doing the same here:DateTimeFeaturization
-->DateTimeFeaturizer