Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DateTimeFeaturization to DateTimeFeaturizer #977

Merged
merged 4 commits into from Jul 24, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Jul 24, 2020

After discussion we named the text featurizer TextFeaturizer because we liked that convention more than TextFeaturization. Doing the same here: DateTimeFeaturization --> DateTimeFeaturizer

@dsherry dsherry added the refactor Work being done to refactor code. label Jul 24, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

Once all tests pass, LGTM! 👍

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

@dsherry I think this is good to merge when all the tests pass!

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM once tests pass

@dsherry dsherry force-pushed the ds_957_rename_datetime_featurizer_files branch from cfa0776 to 838d54b Compare Jul 24, 2020
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #977 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files         174      174           
  Lines        8990     8990           
=======================================
  Hits         8979     8979           
  Misses         11       11           
Impacted Files Coverage Δ
evalml/pipelines/components/__init__.py 100.00% <ø> (ø)
...alml/pipelines/components/transformers/__init__.py 100.00% <100.00%> (ø)
.../components/transformers/preprocessing/__init__.py 100.00% <100.00%> (ø)
.../transformers/preprocessing/datetime_featurizer.py 100.00% <100.00%> (ø)
evalml/pipelines/utils.py 100.00% <100.00%> (ø)
.../tests/component_tests/test_datetime_featurizer.py 100.00% <100.00%> (ø)
...alml/tests/component_tests/test_text_featurizer.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedd427...838d54b. Read the comment docs.

@dsherry dsherry merged commit f172ff5 into main Jul 24, 2020
2 checks passed
@dsherry dsherry deleted the ds_957_rename_datetime_featurizer_files branch Jul 24, 2020
@angela97lin angela97lin mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Work being done to refactor code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants