Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword message when errors are returned from data checks in search #982

Merged
merged 5 commits into from Jul 28, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jul 28, 2020

Rewords the error message that is returned when a user hits an error during search due to data checks per our new API :)

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #982 into main will increase coverage by 0.19%.
The diff coverage is 99.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   99.66%   99.85%   +0.19%     
==========================================
  Files         171      179       +8     
  Lines        8771     9283     +512     
==========================================
+ Hits         8742     9270     +528     
+ Misses         29       13      -16     
Impacted Files Coverage Δ
evalml/data_checks/highly_null_data_check.py 100.00% <ø> (ø)
evalml/demos/fraud.py 100.00% <ø> (ø)
evalml/model_family/utils.py 100.00% <ø> (ø)
evalml/objectives/lead_scoring.py 100.00% <ø> (ø)
evalml/objectives/objective_base.py 100.00% <ø> (ø)
evalml/objectives/utils.py 100.00% <ø> (ø)
evalml/pipelines/binary_classification_pipeline.py 100.00% <ø> (ø)
...valml/pipelines/components/estimators/estimator.py 100.00% <ø> (ø)
...onents/estimators/regressors/baseline_regressor.py 100.00% <ø> (ø)
...components/transformers/encoders/onehot_encoder.py 100.00% <ø> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c828bed...209165f. Read the comment docs.

@angela97lin angela97lin self-assigned this Jul 28, 2020
@angela97lin angela97lin marked this pull request as ready for review Jul 28, 2020
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

@angela97lin Looks good to me!

@angela97lin angela97lin merged commit 74088e0 into main Jul 28, 2020
2 checks passed
Copy link
Collaborator

@dsherry dsherry left a comment

👍

@@ -350,7 +350,7 @@ def search(self, X, y, data_checks="auto", feature_types=None, show_iteration_pl
elif message.message_type == DataCheckMessageType.ERROR:
logger.error(message)
if any([message.message_type == DataCheckMessageType.ERROR for message in self._data_check_results]):
raise ValueError("Data checks raised some warnings and/or errors. Please see `self.data_check_results` for more information or pass data_checks=EmptyDataChecks() to search() to disable data checking.")
raise ValueError("Data checks raised some warnings and/or errors. Please see `self.data_check_results` for more information or pass data_checks='disabled' to search() to disable data checking.")
Copy link
Collaborator

@dsherry dsherry Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@angela97lin angela97lin mentioned this pull request Jul 31, 2020
@angela97lin angela97lin added this to the July 2020 milestone Jul 31, 2020
@angela97lin angela97lin deleted the reword_data_check_message branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants