Reword message when errors are returned from data checks in search #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 99.66% 99.85% +0.19%
==========================================
Files 171 179 +8
Lines 8771 9283 +512
==========================================
+ Hits 8742 9270 +528
+ Misses 29 13 -16
Continue to review full report at Codecov.
|
freddyaboulton
approved these changes
Jul 28, 2020
dsherry
reviewed
Jul 28, 2020
| @@ -350,7 +350,7 @@ def search(self, X, y, data_checks="auto", feature_types=None, show_iteration_pl | |||
| elif message.message_type == DataCheckMessageType.ERROR: | |||
| logger.error(message) | |||
| if any([message.message_type == DataCheckMessageType.ERROR for message in self._data_check_results]): | |||
| raise ValueError("Data checks raised some warnings and/or errors. Please see `self.data_check_results` for more information or pass data_checks=EmptyDataChecks() to search() to disable data checking.") | |||
| raise ValueError("Data checks raised some warnings and/or errors. Please see `self.data_check_results` for more information or pass data_checks='disabled' to search() to disable data checking.") | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewords the error message that is returned when a user hits an error during
searchdue to data checks per our new API :)