Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string in check_for_fit #994

Merged
merged 3 commits into from Jul 29, 2020
Merged

Fix string in check_for_fit #994

merged 3 commits into from Jul 29, 2020

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Jul 29, 2020

Messed up the fstring

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #994 into main will increase coverage by 6.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   93.62%   99.85%   +6.23%     
==========================================
  Files         179      179              
  Lines        9283     9283              
==========================================
+ Hits         8691     9270     +579     
+ Misses        592       13     -579     
Impacted Files Coverage Δ
evalml/pipelines/components/component_base.py 100.00% <100.00%> (ø)
evalml/tests/component_tests/test_components.py 99.57% <100.00%> (+0.21%) ⬆️
evalml/automl/automl_search.py 99.55% <0.00%> (+0.44%) ⬆️
...peline_tests/explanations_tests/test_algorithms.py 100.00% <0.00%> (+1.11%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <0.00%> (+3.28%) ⬆️
evalml/tests/component_tests/test_utils.py 100.00% <0.00%> (+3.57%) ⬆️
...l/pipelines/prediction_explanations/_algorithms.py 100.00% <0.00%> (+4.22%) ⬆️
evalml/pipelines/pipeline_base.py 100.00% <0.00%> (+5.40%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+6.25%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1e295...335af40. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

@jeremyliweishih Thanks for fixing! I checked out this branch and the messages look good to me.

Copy link
Contributor

@angela97lin angela97lin left a comment

Noice 👍

@jeremyliweishih jeremyliweishih merged commit a1f1adb into main Jul 29, 2020
2 checks passed
@angela97lin angela97lin mentioned this pull request Jul 31, 2020
@dsherry dsherry deleted the js_fix_string branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants