You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the FeatureBase object, there are separate methods for getting and setting feature names and feature column names that take the form get_feature_names() and set_feature_names().
These methods should be updated to use a more pythonic approach to getters and setters:
This this would result in the get_name() method being replaced with a .name property and get_feature_names() being replaced by a .feature_names property.
As these changes would constitute a breaking change, we should first implement the new getter/setter approach while leaving the existing .get_*() methods in place, adding a DeprecationWarning to the existing methods, alerting users they should switch to using the new properties.
As part of this update we should also consider renaming feature_names to column_names as that property actually represents the names of the columns that are added to the feature matrix and would provide more differentiation between the name of the Feature object and the name of the output columns that are generated from the feature.
The text was updated successfully, but these errors were encountered:
In the
FeatureBase
object, there are separate methods for getting and setting feature names and feature column names that take the formget_feature_names()
andset_feature_names()
.These methods should be updated to use a more pythonic approach to getters and setters:
This this would result in the
get_name()
method being replaced with a.name
property andget_feature_names()
being replaced by a.feature_names
property.As these changes would constitute a breaking change, we should first implement the new getter/setter approach while leaving the existing
.get_*()
methods in place, adding aDeprecationWarning
to the existing methods, alerting users they should switch to using the new properties.As part of this update we should also consider renaming
feature_names
tocolumn_names
as that property actually represents the names of the columns that are added to the feature matrix and would provide more differentiation between the name of theFeature
object and the name of the output columns that are generated from the feature.The text was updated successfully, but these errors were encountered: