Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only calculate features for instances before cutoff time #437

Closed
kmax12 opened this issue Feb 18, 2019 · 0 comments · Fixed by #523
Closed

Only calculate features for instances before cutoff time #437

kmax12 opened this issue Feb 18, 2019 · 0 comments · Fixed by #523
Assignees
Labels
good first issue Good for newcomers

Comments

@kmax12
Copy link
Contributor

kmax12 commented Feb 18, 2019

Currently, if no instance ids are provided to ft.dfs or ft.calculate_feature_matrix, we calculate features for all instances in the target entity.

However, if a single cutoff time is provided, we only select the instances where the time index is less than or equal to the cutoff time.

The current logic that selects all instance ids is here:
https://github.com/Featuretools/featuretools/blob/72ac0daa7bd60936eeb563b2c352c9a6631f50fc/featuretools/computational_backends/calculate_feature_matrix.py#L142

To fix this issue we have to add logic that checks if the target entity has a time index and removes instances from after the cutoff time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants