We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, if no instance ids are provided to ft.dfs or ft.calculate_feature_matrix, we calculate features for all instances in the target entity.
ft.dfs
ft.calculate_feature_matrix
However, if a single cutoff time is provided, we only select the instances where the time index is less than or equal to the cutoff time.
The current logic that selects all instance ids is here: https://github.com/Featuretools/featuretools/blob/72ac0daa7bd60936eeb563b2c352c9a6631f50fc/featuretools/computational_backends/calculate_feature_matrix.py#L142
To fix this issue we have to add logic that checks if the target entity has a time index and removes instances from after the cutoff time.
The text was updated successfully, but these errors were encountered:
CJStadler
Successfully merging a pull request may close this issue.
Currently, if no instance ids are provided to
ft.dfs
orft.calculate_feature_matrix
, we calculate features for all instances in the target entity.However, if a single cutoff time is provided, we only select the instances where the time index is less than or equal to the cutoff time.
The current logic that selects all instance ids is here:
https://github.com/Featuretools/featuretools/blob/72ac0daa7bd60936eeb563b2c352c9a6631f50fc/featuretools/computational_backends/calculate_feature_matrix.py#L142
To fix this issue we have to add logic that checks if the target entity has a time index and removes instances from after the cutoff time.
The text was updated successfully, but these errors were encountered: