Deal with NaN values in LatLong columns#1007
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 98.28% 98.29% +0.01%
==========================================
Files 121 121
Lines 12397 12474 +77
==========================================
+ Hits 12184 12261 +77
Misses 213 213
Continue to review full report at Codecov.
|
rwedge
reviewed
Jun 2, 2020
added 2 commits
June 2, 2020 15:47
added 4 commits
June 4, 2020 15:16
rwedge
reviewed
Jun 5, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #453
This PR serves as replacement for #693
If a single
Nanvalue was present instead of a tuple in aLatLongcolumns, this could result in indexing errors when using theHaversine,LatitudeorLongitudeprimitives. This PR fixes that issue.A check was put in place during entity creation to replace any
NaNvalues with(NaN, NaN). This check is also implemented in theHaversine,LatitudeandLongitudeprimitives in case the primitive functions is called directly as in the doctests.