New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with NaN
values in LatLong columns
#1007
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 98.28% 98.29% +0.01%
==========================================
Files 121 121
Lines 12397 12474 +77
==========================================
+ Hits 12184 12261 +77
Misses 213 213
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #453
This PR serves as replacement for #693
If a single
Nan
value was present instead of a tuple in aLatLong
columns, this could result in indexing errors when using theHaversine
,Latitude
orLongitude
primitives. This PR fixes that issue.A check was put in place during entity creation to replace any
NaN
values with(NaN, NaN)
. This check is also implemented in theHaversine
,Latitude
andLongitude
primitives in case the primitive functions is called directly as in the doctests.