Add make index to init of EntitySet - #1010
Merged
Merged
Conversation
added 2 commits
June 3, 2020 11:25
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 119 119
Lines 11059 11078 +19
=======================================
+ Hits 10868 10887 +19
Misses 191 191
Continue to review full report at Codecov.
|
ctduffy
previously approved these changes
Jun 3, 2020
ctduffy
left a comment
ctduffy
left a comment
Contributor
There was a problem hiding this comment.
seems to make sense, this init now matches the other parts of entityset better
rwedge
reviewed
Jun 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description