Skip to content

Add make index to init of EntitySet #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 3, 2020
Merged

Add make index to init of EntitySet #1010

merged 5 commits into from
Jun 3, 2020

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 3, 2020

@gsheni gsheni self-assigned this Jun 3, 2020
@gsheni gsheni requested review from rwedge and ctduffy June 3, 2020 15:26
@codecov
Copy link

codecov bot commented Jun 3, 2020 •
edited
Loading

Codecov Report

Merging #1010 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         119      119           
  Lines       11059    11078   +19     
=======================================
+ Hits        10868    10887   +19     
  Misses        191      191
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 96.78% <100.00%> (+0.02%) ⬆️
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c9709...c650ee4. Read the comment docs.

ctduffy
ctduffy previously approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@ctduffy ctduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to make sense, this init now matches the other parts of entityset better

rwedge
rwedge reviewed Jun 3, 2020
View reviewed changes
rwedge
rwedge approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit d42a52d into master Jun 3, 2020
@gsheni gsheni deleted the add_entityset_init branch June 3, 2020 17:32
@rwedge rwedge mentioned this pull request Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@ctduffy ctduffy ctduffy left review comments

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for make index to be specified with init of EntitySet
3 participants
@gsheni @rwedge @ctduffy