Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable types plotting, and variable page to docs #1013

Merged
merged 33 commits into from Jun 12, 2020
Merged

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Jun 3, 2020

Pull Request Description

  • Fixes Create UML-Diagram in Docs for Variable Types #990
  • Created list_variable_types function (similar to list_primitives)
  • Separates out the EntitySet plotting into separate utils file to be used by other functions
  • Moves find_variable_types into utils of variables

@gsheni gsheni self-assigned this Jun 3, 2020
@gsheni gsheni requested a review from rwedge June 3, 2020 18:56
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #1013 into master will increase coverage by 0.02%.
The diff coverage is 98.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   98.26%   98.29%   +0.02%     
==========================================
  Files         121      124       +3     
  Lines       12467    12541      +74     
==========================================
+ Hits        12251    12327      +76     
+ Misses        216      214       -2     
Impacted Files Coverage Δ
featuretools/utils/plot_utils.py 92.00% <92.00%> (ø)
featuretools/entityset/deserialize.py 100.00% <100.00%> (ø)
featuretools/entityset/entity.py 96.16% <100.00%> (ø)
featuretools/entityset/entityset.py 97.63% <100.00%> (+0.40%) ⬆️
featuretools/tests/entityset_tests/test_entity.py 100.00% <100.00%> (ø)
...etools/tests/entityset_tests/test_serialization.py 99.63% <100.00%> (ø)
...aturetools/tests/variables/test_variables_utils.py 100.00% <100.00%> (ø)
featuretools/variable_types/api.py 100.00% <100.00%> (ø)
featuretools/variable_types/utils.py 100.00% <100.00%> (ø)
featuretools/variable_types/variable.py 98.70% <100.00%> (-0.02%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d96bd2...22b4207. Read the comment docs.

@gsheni gsheni marked this pull request as draft June 3, 2020 19:20
@gsheni gsheni requested a review from kmax12 June 5, 2020 23:15
@gsheni gsheni marked this pull request as ready for review June 5, 2020 23:15
@gsheni
Copy link
Member Author

gsheni commented Jun 8, 2020

@gsheni gsheni changed the title [WIP] Add variable types plotting, and variable page to docs Add variable types plotting, and variable page to docs Jun 8, 2020
docs/source/changelog.rst Outdated Show resolved Hide resolved
docs/source/variables.ipynb Outdated Show resolved Hide resolved
docs/source/variables.ipynb Outdated Show resolved Hide resolved
docs/source/variables.ipynb Outdated Show resolved Hide resolved
featuretools/variable_types/utils.py Outdated Show resolved Hide resolved
docs/source/variables.ipynb Outdated Show resolved Hide resolved
docs/source/variables.ipynb Outdated Show resolved Hide resolved
@thehomebrewnerd
Copy link
Collaborator

thehomebrewnerd commented Jun 9, 2020

You might also want to review the documentation in using_dask_entitysets.rst and update the information in the Entity Limitations sections to use list_variable_types() instead of the current suggestion to use featuretools.variable_types.find_variable_types().

@gsheni
Copy link
Member Author

gsheni commented Jun 9, 2020

You might also want to review the documentation in using_dask_entitysets.rst and update the information in the Entity Limitations sections to use list_variable_types() instead of the current suggestion to use featuretools.variable_types.find_variable_types().

@thehomebrewnerd Fixed this.

Copy link
Collaborator

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/source/changelog.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 359d45f into master Jun 12, 2020
2 of 3 checks passed
@gsheni gsheni deleted the add_variable_page branch June 12, 2020 21:25
@rwedge rwedge mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UML-Diagram in Docs for Variable Types
3 participants