Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for numpy v1.19.0 #1016

Merged
merged 4 commits into from Jun 4, 2020
Merged

Updates for numpy v1.19.0 #1016

merged 4 commits into from Jun 4, 2020

Conversation

frances-h
Copy link
Contributor

  • updates failing test due to error message change in numpy

Resolves #977

@frances-h frances-h requested a review from rwedge June 4, 2020 14:33
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #1016 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1016   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         119      119           
  Lines       11078    11078           
=======================================
  Hits        10887    10887           
  Misses        191      191           
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42a52d...5a2944b. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs a contributor

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And go ahead and uncomment the Future Release section

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a line break before the "Thanks to the following..." line

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frances-h frances-h merged commit 5f8adb6 into master Jun 4, 2020
@frances-h frances-h deleted the numpy-1.19-rc branch June 4, 2020 15:39
@rwedge rwedge mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test featuretools with numpy v1.19.0 release candidate
2 participants