Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanly close tqdm #1018

Merged
merged 13 commits into from
Jun 5, 2020
Merged

Cleanly close tqdm #1018

merged 13 commits into from
Jun 5, 2020

Conversation

frances-h
Copy link
Contributor

  • Use with to ensure tqdm instance is closed

Resolves #941

@frances-h frances-h requested a review from rwedge June 5, 2020 13:33
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1018 into master will decrease coverage by 0.00%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
- Coverage   98.29%   98.28%   -0.01%     
==========================================
  Files         121      121              
  Lines       12474    12494      +20     
==========================================
+ Hits        12261    12280      +19     
- Misses        213      214       +1     
Impacted Files Coverage Δ
...etools/tests/entityset_tests/test_serialization.py 99.63% <ø> (ø)
...utational_backend/test_calculate_feature_matrix.py 98.06% <95.65%> (-0.08%) ⬇️
...computational_backends/calculate_feature_matrix.py 98.70% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47673c...aaedacc. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge commented Jun 5, 2020

We also use make_tqdm_iterator in encode_features -- do we need to use a with statement there as well?

rwedge
rwedge previously approved these changes Jun 5, 2020
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rwedge rwedge merged commit 10bcdb8 into master Jun 5, 2020
@rwedge rwedge mentioned this pull request Jun 5, 2020
@rwedge rwedge deleted the close-tqdm branch June 8, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanly close tqdm instance
2 participants