Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing.md #1030

Merged
merged 5 commits into from Jun 16, 2020
Merged

Update contributing.md #1030

merged 5 commits into from Jun 16, 2020

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Jun 15, 2020

@gsheni gsheni self-assigned this Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020 •
edited

Codecov Report

Merging #1030 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
- Coverage   98.29%   98.27%   -0.02%     
==========================================
  Files         124      124              
  Lines       12541    12541              
==========================================
- Hits        12327    12325       -2     
- Misses        214      216       +2
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 97.34% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359d45f...f07e4bc. Read the comment docs.

@gsheni gsheni requested a review from rwedge June 16, 2020 13:01
rwedge
rwedge reviewed Jun 16, 2020
View reviewed changes
contributing.md Outdated Show resolved Hide resolved
rwedge
rwedge approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit f1491ea into master Jun 16, 2020
@gsheni gsheni deleted the add_dev_install_instructions branch June 16, 2020 15:29
@rwedge rwedge mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention how to install featuretools for development in contributing.md
2 participants
@gsheni @rwedge