Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature lineage visualization #1032

Merged
merged 13 commits into from Jun 30, 2020
Merged

Feature lineage visualization #1032

merged 13 commits into from Jun 30, 2020

Conversation

frances-h
Copy link
Contributor

@frances-h frances-h commented Jun 23, 2020

Add graph_feature function which takes in a feature and returns a graph demonstrating how the feature was generated:

simple_transform

trans_agg_stacked

Closes #937

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #1032 into master will increase coverage by 0.04%.
The diff coverage is 99.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   98.30%   98.35%   +0.04%     
==========================================
  Files         124      126       +2     
  Lines       12695    13052     +357     
==========================================
+ Hits        12480    12837     +357     
  Misses        215      215              
Impacted Files Coverage Δ
featuretools/feature_base/feature_visualizer.py 98.52% <98.52%> (ø)
featuretools/__init__.py 82.35% <100.00%> (ø)
featuretools/feature_base/api.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_feature_visualizer.py 100.00% <100.00%> (ø)
featuretools/synthesis/deep_feature_synthesis.py 97.83% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21606a...00dfffe. Read the comment docs.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested with quite a few different feature types and the output matched my expectations.

The only suggestion I have is to maybe add a mention of this capability to the documentation as this is a nice way to understand more about your features. Not sure exactly, where would be the best place but maybe here: Deep Feature Synthesis.

@frances-h frances-h requested a review from rwedge June 25, 2020 12:51
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/setup.py Outdated Show resolved Hide resolved
docs/source/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once it's up to date!

@frances-h frances-h merged commit ebf8b84 into master Jun 30, 2020
@frances-h frances-h deleted the feature-visualization branch June 30, 2020 18:47
@rwedge rwedge mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph feature lineage
4 participants