Skip to content

Error if relationship child variable is child entity index#1034

Merged
frances-h merged 5 commits into
masterfrom
add-relationship-error
Jun 26, 2020
Merged

Error if relationship child variable is child entity index#1034
frances-h merged 5 commits into
masterfrom
add-relationship-error

Conversation

@frances-h
Copy link
Copy Markdown
Contributor

Error when adding an EntitySet relationship if the child variable is also the child entity's index
closes #1009

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2020

Codecov Report

Merging #1034 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         124      124           
  Lines       12587    12598   +11     
=======================================
+ Hits        12373    12384   +11     
  Misses        214      214           
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 97.65% <100.00%> (+0.01%) ⬆️
featuretools/tests/entityset_tests/test_es.py 99.85% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71d19c...0cf4eb2. Read the comment docs.

Copy link
Copy Markdown
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this situation occur if the user passes entities and relationships to ft.dfs instead of calling add_relationship directly? If so, we might want a more descriptive error message.

Copy link
Copy Markdown
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h frances-h merged commit 95117a7 into master Jun 26, 2020
@frances-h frances-h deleted the add-relationship-error branch June 26, 2020 19:31
@rwedge rwedge mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EntitySet.add_relationship should error if the child variable is also the index variable of the child entity

2 participants