Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have CircleCI fail if codecov fails to upload #1035

merged 2 commits into from Jun 26, 2020


Copy link

Add required flag to codecov upload command so failure to upload triggers a CircleCI failure

Closes #997

Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1035 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
  Coverage   98.29%   98.29%           
  Files         124      124           
  Lines       12587    12587           
  Hits        12373    12373           
  Misses        214      214           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69c327...216c34e. Read the comment docs.

@frances-h frances-h requested a review from rwedge June 26, 2020 13:54
rwedge approved these changes Jun 26, 2020
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h frances-h merged commit a71d19c into master Jun 26, 2020
3 checks passed
@frances-h frances-h deleted the codecov-circleci-fail branch June 26, 2020 15:06
@rwedge rwedge mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Have CI report failure if codecov upload fails
2 participants