use mock_customer fixture - #1036
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1036 +/- ##
=======================================
Coverage ? 98.35%
=======================================
Files ? 126
Lines ? 13036
Branches ? 0
=======================================
Hits ? 12821
Misses ? 215
Partials ? 0 Continue to review full report at Codecov.
|
|
This entityset is also used in I think we should also move this fixture definition to |
|
@thehomebrewnerd please review and let me know if I should change anything. |
The codecov issue is likely because you are reducing the number of total lines of code, so the percent covered is decreasing. |
|
@systemshift Please merge in the latest changes from |
…d_mock_customer_fixture
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the contribution!
Pull Request Description
closes #1001
Unless I misunderstood, the issue has been mostly solved with the exception of this single case.
There are only 3 times
ft.demo.load_mock_customeris called in tests, 2 already have fixtures.After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.