New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use mock_customer fixture #1036
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1036 +/- ##
=======================================
Coverage ? 98.35%
=======================================
Files ? 126
Lines ? 13036
Branches ? 0
=======================================
Hits ? 12821
Misses ? 215
Partials ? 0 Continue to review full report at Codecov.
|
This entityset is also used in I think we should also move this fixture definition to |
@thehomebrewnerd please review and let me know if I should change anything. |
featuretools/tests/computational_backend/test_calculate_feature_matrix.py
Outdated
Show resolved
Hide resolved
The codecov issue is likely because you are reducing the number of total lines of code, so the percent covered is decreasing. |
@systemshift Please merge in the latest changes from |
…d_mock_customer_fixture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Pull Request Description
closes #1001
Unless I misunderstood, the issue has been mostly solved with the exception of this single case.
There are only 3 times
ft.demo.load_mock_customer
is called in tests, 2 already have fixtures.After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.