Skip to content

use mock_customer fixture - #1036

Merged
rwedge merged 22 commits into
alteryx:mainfrom
systemshift:load_mock_customer_fixture
Jul 2, 2020
Merged

use mock_customer fixture#1036
rwedge merged 22 commits into
alteryx:mainfrom
systemshift:load_mock_customer_fixture

Conversation

@systemshift

Copy link
Copy Markdown
Contributor

Pull Request Description

closes #1001
Unless I misunderstood, the issue has been mostly solved with the exception of this single case.
There are only 3 times ft.demo.load_mock_customer is called in tests, 2 already have fixtures.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov

codecov Bot commented Jun 28, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@45998e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage        ?   98.35%           
=======================================
  Files           ?      126           
  Lines           ?    13036           
  Branches        ?        0           
=======================================
  Hits            ?    12821           
  Misses          ?      215           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45998e8...3cef57a. Read the comment docs.

@thehomebrewnerd

thehomebrewnerd commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

This entityset is also used in test_demo_data.py on Line 26.

I think we should also move this fixture definition to conftest.py along with the Dask version, and parameterize them like we have done with the other fixtures. See test_calculate_feature_matrix.py Line 1458 for the fixture definitions. We should then make sure that there are no versions of this fixture defined in the individual tests files unless there is some specific need to do so.

@systemshift

systemshift commented Jun 29, 2020

Copy link
Copy Markdown
Contributor Author

@thehomebrewnerd please review and let me know if I should change anything.
I do not know what is causing the codecov issue, given that I haven't touched that file.

Comment thread docs/source/changelog.rst Outdated
Comment thread featuretools/tests/computational_backend/test_calculate_feature_matrix.py Outdated
Comment thread featuretools/tests/demo_tests/test_demo_data.py Outdated
Comment thread featuretools/tests/utils_tests/test_entity_utils.py Outdated
Comment thread featuretools/tests/utils_tests/test_entity_utils.py Outdated
@thehomebrewnerd

Copy link
Copy Markdown
Contributor

@thehomebrewnerd please review and let me know if I should change anything.
I do not know what is causing the codecov issue, given that I haven't touched that file.

The codecov issue is likely because you are reducing the number of total lines of code, so the percent covered is decreasing.

@thehomebrewnerd

Copy link
Copy Markdown
Contributor

@systemshift Please merge in the latest changes from featuretools/master and resolve the conflicts in changelog.rst.

Comment thread docs/source/changelog.rst Outdated
Comment thread docs/source/changelog.rst Outdated
thehomebrewnerd
thehomebrewnerd previously approved these changes Jul 2, 2020

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution!

@thehomebrewnerd
thehomebrewnerd requested a review from rwedge July 2, 2020 13:33
@rwedge
rwedge changed the base branch from master to main July 2, 2020 18:30
@rwedge
rwedge dismissed thehomebrewnerd’s stale review July 2, 2020 18:30

The base branch was changed.

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rwedge
rwedge merged commit 8693e5c into alteryx:main Jul 2, 2020
@systemshift
systemshift deleted the load_mock_customer_fixture branch July 23, 2020 03:07
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a pytest fixture for load_mock_customer in tests

3 participants