New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TimeSince primitive. Make it work with all Datetime subclasses #1048
Fix TimeSince primitive. Make it work with all Datetime subclasses #1048
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 98.33% 98.35% +0.01%
==========================================
Files 126 126
Lines 13033 13039 +6
==========================================
+ Hits 12816 12824 +8
+ Misses 217 215 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge in the latest changes from the Featuretools main
branch. After doing this, verify your new changelog entry is in the proper location. Also, please add your username to the list of contributors in the Future Release section.
@thehomebrewnerd I've updated the PR, thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monti-python Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, thanks for the contribution!
I updated the wording of the changelog entry a bit
Pull Request Description
fixes #1047