Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeSince primitive. Make it work with all Datetime subclasses #1048

Merged

Conversation

monti-python
Copy link
Contributor

@monti-python monti-python commented Jul 3, 2020

Pull Request Description

fixes #1047

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #1048 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
+ Coverage   98.33%   98.35%   +0.01%     
==========================================
  Files         126      126              
  Lines       13033    13039       +6     
==========================================
+ Hits        12816    12824       +8     
+ Misses        217      215       -2     
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100.00% <100.00%> (ø)
...s/tests/primitive_tests/test_transform_features.py 98.81% <100.00%> (+0.01%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 97.83% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d4009...22de2fe. Read the comment docs.

Copy link
Collaborator

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge in the latest changes from the Featuretools main branch. After doing this, verify your new changelog entry is in the proper location. Also, please add your username to the list of contributors in the Future Release section.

@monti-python
Copy link
Contributor Author

@thehomebrewnerd I've updated the PR, thanks for reviewing!

thehomebrewnerd
thehomebrewnerd previously approved these changes Jul 7, 2020
Copy link
Collaborator

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monti-python Thanks for the contribution!

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, thanks for the contribution!

I updated the wording of the changelog entry a bit

@rwedge rwedge merged commit 7a823ab into alteryx:main Jul 7, 2020
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeSince primitive works only with DatetimeTimeIndex type
4 participants