-
Notifications
You must be signed in to change notification settings - Fork 896
Fix issue with missing instances and categorical entity index #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1050 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 126 126
Lines 13082 13082
=======================================
Hits 12867 12867
Misses 215 215
Continue to review full report at Codecov.
|
@rwedge Added checks to make sure that the feature matrix has a categorical index, if the target entity has a categorical index. If the user supplies an instance id that is not in the target entity, the index categories will be different in the feature matrix (to account for adding the missing ids), but the index dtype will be maintained. This change required some updates to a few tests which had errors due to an invalid indexing approach being used for a series with a categorical index. For example, |
featuretools/tests/computational_backend/test_calculate_feature_matrix.py
Show resolved
Hide resolved
featuretools/tests/computational_backend/test_feature_set_calculator.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixes #1046
Changed order of operations in merging default dataframe into feature matrix to allow combination of categorical and integer indexes. Added test case to cover this situation.