New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor dask test units #1052
refactor dask test units #1052
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 126 126
Lines 13039 13067 +28
=======================================
+ Hits 12824 12852 +28
Misses 215 215
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_calls_progress_callback
in test_calculate_feature_matrix.py
and test_dfs_method.py
also could be split out
featuretools/tests/computational_backend/test_calculate_feature_matrix.py
Show resolved
Hide resolved
Test units pass on these two, but as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the TODO: split out comment above test_cfm_returns_original_time_indexes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Pull Request Description
should close #1002.
reviews welcome while work still in progress.
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.