Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor dask test units #1052

Merged
merged 17 commits into from Jul 9, 2020
Merged

Conversation

systemshift
Copy link
Contributor

Pull Request Description

should close #1002.
reviews welcome while work still in progress.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@systemshift systemshift changed the title split cutoff_time_extra_columns refactor dask test units Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1052 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         126      126           
  Lines       13039    13067   +28     
=======================================
+ Hits        12824    12852   +28     
  Misses        215      215           
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 98.19% <100.00%> (+0.03%) ⬆️
featuretools/tests/synthesis/test_dfs_method.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec73e68...31f6d74. Read the comment docs.

Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_calls_progress_callback in test_calculate_feature_matrix.py and test_dfs_method.py also could be split out

@systemshift
Copy link
Contributor Author

test_calls_progress_callback in test_calculate_feature_matrix.py and test_dfs_method.py also could be split out

Test units pass on these two, but as xfail. If that is acceptable then the PR is ready to merge, if not, would like to know how to work around this one.

Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the TODO: split out comment above test_cfm_returns_original_time_indexes

featuretools/tests/synthesis/test_dfs_method.py Outdated Show resolved Hide resolved
featuretools/tests/synthesis/test_dfs_method.py Outdated Show resolved Hide resolved
@systemshift systemshift requested a review from rwedge July 9, 2020 04:16
Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rwedge rwedge merged commit 9253091 into alteryx:main Jul 9, 2020
3 checks passed
@systemshift systemshift deleted the refactor_dask_tests branch July 23, 2020 03:07
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor various tests for Dask implementation
2 participants