Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings.simplefilter #1053

merged 2 commits into from Jul 7, 2020

Remove warnings.simplefilter #1053

merged 2 commits into from Jul 7, 2020


Copy link

@gsheni gsheni commented Jul 7, 2020

Pull Request Description

  • Remove filters that were silencing warnings

@gsheni gsheni self-assigned this Jul 7, 2020
@gsheni gsheni changed the title Update Remove warnings.simplefilter Jul 7, 2020
@gsheni gsheni requested a review from rwedge July 7, 2020 20:35
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

No coverage uploaded for pull request base (main@123fe85). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1053   +/-   ##
  Coverage        ?   98.35%           
  Files           ?      126           
  Lines           ?    13033           
  Branches        ?        0           
  Hits            ?    12818           
  Misses          ?      215           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123fe85...e4fa854. Read the comment docs.

Copy link
Member Author

gsheni commented Jul 7, 2020

rwedge approved these changes Jul 7, 2020
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can investigate nlp primitives warning after merging

@gsheni gsheni merged commit 44d4009 into main Jul 7, 2020
3 checks passed
@gsheni gsheni deleted the remove_blanket_warnings_filter branch July 7, 2020 21:31
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants