Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warnings.simplefilter #1053

Merged
merged 2 commits into from Jul 7, 2020
Merged

Remove warnings.simplefilter #1053

merged 2 commits into from Jul 7, 2020

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Jul 7, 2020

Pull Request Description

  • Remove filters that were silencing warnings

@gsheni gsheni self-assigned this Jul 7, 2020
@gsheni gsheni changed the title Update feature_set_calculator.py Remove warnings.simplefilter Jul 7, 2020
@gsheni gsheni requested a review from rwedge July 7, 2020 20:35
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@123fe85). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1053   +/-   ##
=======================================
  Coverage        ?   98.35%           
=======================================
  Files           ?      126           
  Lines           ?    13033           
  Branches        ?        0           
=======================================
  Hits            ?    12818           
  Misses          ?      215           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123fe85...e4fa854. Read the comment docs.

@gsheni
Copy link
Member Author

gsheni commented Jul 7, 2020

Documentation Preview Here: https://docs.featuretools.com/en/remove_blanket_warnings_filter/index.html

rwedge
rwedge approved these changes Jul 7, 2020
View changes
Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can investigate nlp primitives warning after merging

@gsheni gsheni merged commit 44d4009 into main Jul 7, 2020
3 checks passed
@gsheni gsheni deleted the remove_blanket_warnings_filter branch July 7, 2020 21:31
@rwedge rwedge mentioned this pull request Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsheni @rwedge