Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature visualization for features with '<' or '>' in name #1055

Merged
merged 6 commits into from
Jul 9, 2020

Conversation

frances-h
Copy link
Contributor

Replace '>' and '<' in feature names with HTML escape characters to fix graphviz parsing error

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #1055 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1055   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         126      126           
  Lines       13067    13082   +15     
=======================================
+ Hits        12852    12867   +15     
  Misses        215      215           
Impacted Files Coverage Δ
featuretools/feature_base/feature_visualizer.py 98.56% <100.00%> (+0.03%) ⬆️
...s/tests/primitive_tests/test_feature_visualizer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f9788...0e06eb4. Read the comment docs.

@frances-h frances-h requested a review from rwedge July 8, 2020 19:50
@@ -6,6 +6,7 @@ Changelog
* Enhancements
* Fixes
* Remove warnings.simplefilter in feature_set_calculator to un-silence warnings (:pr:`1053`)
* Fix feature visualzation for features with '>' or '<' in name (:pr:`1055`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visualzation

should be visualization

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h frances-h merged commit a26e7f7 into main Jul 9, 2020
@frances-h frances-h deleted the feat-viz-fix branch July 9, 2020 17:21
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants