Skip to content

Add more ignore branch filters to changelog check #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jul 9, 2020

Ignore the changelog update check for release PRs and dependency update prs

I initally tested the ignore filter list by adding a rule to ignore this branch and removing the rule after confirming the changelog test was not used.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1057 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         126      126           
  Lines       13082    13082           
=======================================
  Hits        12867    12867           
  Misses        215      215           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26e7f7...cd1735b. Read the comment docs.

@rwedge rwedge requested a review from thehomebrewnerd July 9, 2020 17:05
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rwedge rwedge merged commit b5d87bf into main Jul 9, 2020
@rwedge rwedge deleted the more-changelog-ignore-cases branch July 9, 2020 17:42
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants