Convert text variable to string before NumWords #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 88.18% 88.17% -0.02%
==========================================
Files 73 73
Lines 7392 7394 +2
==========================================
+ Hits 6519 6520 +1
- Misses 873 874 +1
Continue to review full report at Codecov.
|
kmax12
reviewed
Mar 8, 2018
| return lambda array: pd.Series([x.count(" ") + 1 for x in array]) | ||
| def word_counter(array): | ||
| array = pd.Series(array).fillna('') | ||
| return pd.Series([str(x).count(' ') + 1 for x in array]) |
There was a problem hiding this comment.
Can you just do pd.Series(array).fillna('').str.count(" ") + 1?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error that NumWords gives if it encounters a float. This comes up often, as
np.NaNis a float. An alternate solution would be to catch the NaNs directly and return 0 or NaN rather than 1.