check input variable type for .delete_variables()

[systemshift]

Pull Request Description

close #1059

If someone has better warning string that is more informative let me know.

---

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

[codecov]

Codecov Report

Merging #1064 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         126      126           
  Lines       13089    13098    +9     
=======================================
+ Hits        12874    12883    +9     
  Misses        215      215           

Impacted Files	Coverage Δ
featuretools/entityset/entity.py	96.19% <100.00%> (+0.02%)	⬆️
featuretools/tests/entityset_tests/test_entity.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48a9c5...ade296e. Read the comment docs.

[thehomebrewnerd]

Let's also update the docstring for this method to include information on the arguments that are acceptable and the return value (none). For an example, look at the docstring for the add_interesting_values method.

[thehomebrewnerd]

Looking good, but please also update the docstring for delete_variables() to more clearly indicate what is expected for the variable_ids argument.

[systemshift]

Looking good, but please also update the docstring for delete_variables() to more clearly indicate what is expected for the variable_ids argument.

should I add anything else?

[thehomebrewnerd]

Looks good

[rwedge]

For the test case, can we confirm that the variable was not deleted, similar to how we check variables were removed in test_delete_variables

[rwedge]

Looks good