Skip to content

add custom variables type section in docs#1066

Merged
gsheni merged 7 commits into
mainfrom
add_custom_variables_docs
Jul 17, 2020
Merged

add custom variables type section in docs#1066
gsheni merged 7 commits into
mainfrom
add_custom_variables_docs

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Jul 16, 2020

Custom Variables Type section in Docs

@gsheni gsheni requested a review from rwedge July 16, 2020 13:57
@gsheni gsheni self-assigned this Jul 16, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #1066 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         126      126           
  Lines       13082    13082           
=======================================
  Hits        12867    12867           
  Misses        215      215

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1a9ab...244eeb4. Read the comment docs.

@gsheni
Copy link
Copy Markdown
Contributor Author

gsheni commented Jul 16, 2020 •
edited
Loading

Page on preview docs:
https://docs.featuretools.com/en/add_custom_variables_docs/variables.html

rwedge
rwedge reviewed Jul 16, 2020
View reviewed changes
Comment thread docs/source/variables.ipynb Outdated
Comment thread docs/source/variables.ipynb Outdated
@gsheni
Copy link
Copy Markdown
Contributor Author

gsheni commented Jul 16, 2020

@rwedge also added a working section on using DFS and showing feature output

rwedge
rwedge reviewed Jul 16, 2020
View reviewed changes
Comment thread docs/source/variables.ipynb Outdated
rwedge
rwedge reviewed Jul 16, 2020
View reviewed changes
Comment thread docs/source/variables.ipynb Outdated
rwedge
rwedge approved these changes Jul 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 8c434ff into main Jul 17, 2020
@rwedge rwedge mentioned this pull request Jul 31, 2020
Merged
@rwedge rwedge deleted the add_custom_variables_docs branch February 19, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rwedge rwedge rwedge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document how to add custom variable types

2 participants

@gsheni @rwedge