Make Dask transform test deterministic - #1070
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 126 126
Lines 13082 13089 +7
=======================================
+ Hits 12867 12874 +7
Misses 215 215
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_dask_primitives.py::test_transformwas not deterministic, causing a different set of features to be used from run to run. This resulted in small differences in code coverage between runs. This PR, updates this test to make sure the same set of features are always used.Note: the root of this issue is that when using max_features, the same set of features are not always returned by dfs (see issue #833). The updates in this PR are only a needed as a temporary measure until #833 is fixed.