Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dask transform test deterministic #1070

merged 2 commits into from Jul 17, 2020

Make Dask transform test deterministic #1070

merged 2 commits into from Jul 17, 2020


Copy link

The test was not deterministic, causing a different set of features to be used from run to run. This resulted in small differences in code coverage between runs. This PR, updates this test to make sure the same set of features are always used.

Note: the root of this issue is that when using max_features, the same set of features are not always returned by dfs (see issue #833). The updates in this PR are only a needed as a temporary measure until #833 is fixed.

Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #1070 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1070   +/-   ##
  Coverage   98.35%   98.35%           
  Files         126      126           
  Lines       13082    13089    +7     
+ Hits        12867    12874    +7     
  Misses        215      215           
Impacted Files Coverage Δ
...ools/tests/primitive_tests/ 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c434ff...1f2cdd0. Read the comment docs.

rwedge approved these changes Jul 17, 2020
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thehomebrewnerd thehomebrewnerd merged commit 66afe7f into main Jul 17, 2020
3 checks passed
@thehomebrewnerd thehomebrewnerd deleted the codecov-fix branch July 17, 2020 14:25
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants