Warn user if primitives are unused during dfs#1073
Merged
thehomebrewnerd merged 22 commits intomainfrom Jul 30, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1073 +/- ##
==========================================
+ Coverage 98.35% 98.36% +0.01%
==========================================
Files 126 126
Lines 13161 13267 +106
==========================================
+ Hits 12944 13050 +106
Misses 217 217
Continue to review full report at Codecov.
|
gsheni
reviewed
Jul 21, 2020
frances-h
reviewed
Jul 21, 2020
rwedge
reviewed
Jul 24, 2020
rwedge
reviewed
Jul 30, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements changes that will issue a warning if a user supplies primitives to
dfsthat do not get used in generating the feature matrix. If the default primitives are used, this check is not performed - the check only happens when the user supplies a list of primitives.Added tests to check for warnings in a variety of situations including trans_primitives, agg_primitives, where_primitives, groupby_trans_primitives and custom primitives.