-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Pandas 1.1.0 #1079
Fixes for Pandas 1.1.0 #1079
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
- Coverage 98.36% 98.35% -0.02%
==========================================
Files 126 126
Lines 13158 13161 +3
==========================================
+ Hits 12943 12944 +1
- Misses 215 217 +2
Continue to review full report at Codecov.
|
The fixes implemented in this PR were verified to work with pandas versions as old as |
Based on limited testing, this code |
For all these If not, I think we should make a |
requirements.txt
Outdated
@@ -1,6 +1,6 @@ | |||
scipy>=0.13.3 | |||
numpy>=1.13.3 | |||
pandas>=0.24.1,<1.1.0 | |||
pandas>=1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any changes that require using 1.0 or higher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - the changes in wrangle.py
don't work with older versions because of the way the date offsets are handled. There might be a way to come up with something that would work with both, but I'd have to spend some more time looking into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be able to use a different if-else
construct to check for the two scenarios that were present in the previous code. I'll check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixes #1072
wrangle.py
to change handling for special date offsets to support both older and newer versions of pandas1.0.0
as changes to needed inwrangle.py
to work with1.1.0
will cause failures with older versions.2.12.0
to avoid error that happens with version2.11.0
which does not implementdd.to_numeric()