Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uint8 casting for encode_features boolean columns #1082

Merged
merged 3 commits into from Jul 23, 2020

Conversation

tamargrey
Copy link
Contributor

The boolean columns produced by encode_features used dtype uint8, while dfs and calculate_feature_matrix use True/False bools. We're switching encode_features to bools as well for consistency.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@tamargrey tamargrey requested a review from rwedge July 22, 2020 21:44
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1082 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
+ Coverage   98.34%   98.36%   +0.01%     
==========================================
  Files         126      126              
  Lines       13123    13132       +9     
==========================================
+ Hits        12906    12917      +11     
+ Misses        217      215       -2     
Impacted Files Coverage Δ
featuretools/synthesis/encode_features.py 98.57% <100.00%> (ø)
...aturetools/tests/synthesis/test_encode_features.py 100.00% <100.00%> (ø)
featuretools/synthesis/deep_feature_synthesis.py 97.83% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be08f88...020ba69. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to update the changelog and add yourself to the list of contributors!

featuretools/tests/synthesis/test_encode_features.py Outdated Show resolved Hide resolved
docs/source/changelog.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants