-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update primitive options to check reversed inputs if commutative #1085
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 126 126
Lines 13132 13158 +26
=======================================
+ Hits 12915 12941 +26
Misses 217 217
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a few tests and the results matched what I expected, but I think the new test needs to be updated as it doesn't seem to be working quite right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Updates primitive option matching to also check reversed inputs if primitive is commutative. Only checks reverse if first ordering fails to prevent double features from being created.
Fixes #1075