Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update primitive options to check reversed inputs if commutative #1085

Merged
merged 8 commits into from
Jul 28, 2020

Conversation

frances-h
Copy link
Contributor

Updates primitive option matching to also check reversed inputs if primitive is commutative. Only checks reverse if first ordering fails to prevent double features from being created.

Fixes #1075

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #1085 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   98.34%   98.35%           
=======================================
  Files         126      126           
  Lines       13132    13158   +26     
=======================================
+ Hits        12915    12941   +26     
  Misses        217      217           
Impacted Files Coverage Δ
featuretools/primitives/options_utils.py 100.00% <100.00%> (ø)
featuretools/synthesis/deep_feature_synthesis.py 97.34% <100.00%> (ø)
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.24% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aaf1d7...5065edd. Read the comment docs.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a few tests and the results matched what I expected, but I think the new test needs to be updated as it doesn't seem to be working quite right.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h frances-h requested a review from rwedge July 27, 2020 14:45
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h frances-h merged commit 3569038 into main Jul 28, 2020
@frances-h frances-h deleted the subtract-numeric-options branch July 28, 2020 20:50
@rwedge rwedge mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built-in subtract_numeric primitive ignores certain variables
3 participants