Sort matching_inputs to get consistent ordering#1088
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
- Coverage 98.36% 98.36% -0.01%
==========================================
Files 126 126
Lines 13275 13272 -3
==========================================
- Hits 13058 13055 -3
Misses 217 217
Continue to review full report at Codecov.
|
tamargrey
force-pushed
the
fix-nondeterministic-dfs
branch
3 times, most recently
from
23ac1ff to
0eb831f
Compare
tamargrey
force-pushed
the
fix-nondeterministic-dfs
branch
from
0eb831f to
65ccea6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Using sets for
matching_inputsmeans that with different kernel restarts, we could get different orders of features. By sorting a list of thematching_inputsbefore creating the features, we get consistent results.