Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort matching_inputs to get consistent ordering #1088

merged 5 commits into from Jul 31, 2020


Copy link

Pull Request Description

Using sets for matching_inputs means that with different kernel restarts, we could get different orders of features. By sorting a list of the matching_inputs before creating the features, we get consistent results.

Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1088 into main will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1088      +/-   ##
- Coverage   98.36%   98.36%   -0.01%     
  Files         126      126              
  Lines       13275    13272       -3     
- Hits        13058    13055       -3     
  Misses        217      217              
Impacted Files Coverage Δ
featuretools/primitives/ 100.00% <100.00%> (ø)
...ools/tests/primitive_tests/ 100.00% <100.00%> (ø)
...ests/primitive_tests/ 99.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111d0c4...65ccea6. Read the comment docs.

@tamargrey tamargrey requested a review from rwedge July 28, 2020 15:48
@tamargrey tamargrey force-pushed the fix-nondeterministic-dfs branch 3 times, most recently from 23ac1ff to 0eb831f Compare July 31, 2020 19:13
rwedge approved these changes Jul 31, 2020
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tamargrey tamargrey merged commit 786c400 into main Jul 31, 2020
2 of 3 checks passed
@rwedge rwedge mentioned this pull request Jul 31, 2020
@rwedge rwedge deleted the fix-nondeterministic-dfs branch February 19, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants