Better test case for normalizing from no time index to time index#1113
Better test case for normalizing from no time index to time index#1113
Conversation
|
A couple things I'm unsure about:
|
Codecov Report
@@ Coverage Diff @@
## main #1113 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 126 126
Lines 13257 13268 +11
=======================================
+ Hits 13040 13051 +11
Misses 217 217
Continue to review full report at Codecov.
|
gsheni
left a comment
gsheni
left a comment
There was a problem hiding this comment.
Looks good. Update the changelog.
tamargrey
force-pushed
the
test-normalize-from-none
branch
from
16fec8a to
fedc197
Compare
| df = pd.DataFrame({ | ||
| "id": [0, 1, 2, 3], | ||
| "A": [5, 4, 2, 3], | ||
| 'time': [datetime(2020, 6, 3), (datetime(2020, 3, 12)), datetime(2020, 5, 1), datetime(2020, 4, 22)] | ||
| }) | ||
| es = ft.EntitySet("es") | ||
| es = es.entity_from_dataframe( | ||
| entity_id="data", | ||
| dataframe=df, | ||
| index="id") |
There was a problem hiding this comment.
the old version of this test is testing both a dask entityset and a pandas one. We could make a parametrized entityset fixture similar to es with this portion of the code, and keep the rest of the code to test the entityset
There was a problem hiding this comment.
Added in the fixtures so we now have params=['dd_normalize_es', 'pd_normalize_es'] for this test-- let me know if it looks ok
tamargrey
force-pushed
the
test-normalize-from-none
branch
from
2f581e9 to
10c8b3a
Compare
3 participants
Updated test case
Creates an entity set with one entity that does not have a
time_indexbut does have a column of datetimes. That column,timeis used viamake_time_indexas the time index of an entity built from normalization.