Conversation
Codecov Report
@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 126 126
Lines 13309 13308 -1
==========================================
- Hits 13090 13089 -1
Misses 219 219
Continue to review full report at Codecov.
|
tamargrey
commented
Sep 4, 2020
| dependencies.extend(feature_deps) | ||
|
|
||
| explored.append(feature.get_name()) | ||
| explored.add(feature.get_name()) |
Contributor
Author
There was a problem hiding this comment.
This won't catch the case where there are multiple versions of a primitive set with different parameters but one was unused. It wasn't caught before, and the question of what are unique primitive and feature names is outside the scope of this PR, so we'll revisit this at a later date via #1141
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check in
dfsfor unused primitives has been blowing up at the check for unused primitives when dfs produces many features. This PR makes two changes to help slow that down:_categorize_featuresnow returns just the primitives used categorized into primitive types, meaning that ifsumwas used 4000 times, it only needs one entry in the categorization. This makes the check for unused primitives dependent on the number of possible primitives and not the number of possible features.exploredin_categorize_featuresis changed to be a set so that when we checkexploredto avoid repeating features, it's a constant time checkNote: This PR will go along with a change to the performance tests FeatureLabs/EntitySets#115 to include a test that produces more than 50K features so that we can see the impacts of this PR and future changes that might impact
dfsat larger numbers of features