Update sklearn transformer requirements #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated to changed here but issue seem to be due to update of moto library: could probably fix by using moto[all] or selecting the relevant services |
Codecov Report
@@ Coverage Diff @@
## main #1145 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 129 129
Lines 13852 13852
=======================================
Hits 13658 13658
Misses 194 194 Continue to review full report at Codecov.
|
tamargrey
force-pushed
the
sklearn-transformer-reqs
branch
from
c6fa2ee to
9010d54
Compare
rwedge
reviewed
Sep 8, 2020
test-requirements.txt
Outdated
| @@ -5,7 +5,7 @@ pytest-xdist==1.26.1 | |||
| pytest-cov==2.6.1 | |||
| fastparquet>=0.1.6 | |||
| graphviz>=0.8.4 | |||
| moto>=1.3.13 | |||
| moto[all]>=1.3.13 | |||
There was a problem hiding this comment.
if we're going to set a minimum requirement let's use the latest (1.3.15). It's the first version to introduce the optional requirements, and since this is the test requirements we can be more aggressive about requiring the latest versions
rwedge
approved these changes
Sep 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to 0.1.1 to go with the remove transform stacking PR changes.