Serialize multi output features#1150
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage 98.59% 98.60%
=======================================
Files 129 129
Lines 13852 13877 +25
=======================================
+ Hits 13658 13683 +25
Misses 194 194
Continue to review full report at Codecov.
|
tamargrey
force-pushed
the
serialize-multi-output-features
branch
from
September 9, 2020 18:51
2014ed1 to
e4df43e
Compare
rwedge
reviewed
Sep 10, 2020
tamargrey
force-pushed
the
serialize-multi-output-features
branch
from
September 10, 2020 14:49
e4df43e to
7676529
Compare
rwedge
reviewed
Sep 11, 2020
rwedge
left a comment
rwedge
left a comment
Contributor
There was a problem hiding this comment.
Looks like there are some conflicts with the main branch.
I like the new dictionary tests, let's also test an agg with a where feature, and a groupy transform feature
tamargrey
force-pushed
the
serialize-multi-output-features
branch
from
September 11, 2020 19:27
85377be to
58ac095
Compare
rwedge
reviewed
Sep 14, 2020
rwedge
left a comment
rwedge
left a comment
Contributor
There was a problem hiding this comment.
looks good, but out of date with main again
tamargrey
force-pushed
the
serialize-multi-output-features
branch
from
September 14, 2020 17:40
58ac095 to
0b0b4ea
Compare
rwedge
approved these changes
Sep 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FeatureOutputSlicefeatures were unable to be serialized, so this PR changes theirbase_featurefield of the arguments dictionary to be the feature name instead of an actual feature object itself.