Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize multi output features #1150

Merged
merged 6 commits into from Sep 14, 2020
Merged

Conversation

tamargrey
Copy link
Contributor

FeatureOutputSlice features were unable to be serialized, so this PR changes their base_feature field of the arguments dictionary to be the feature name instead of an actual feature object itself.

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #1150 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   98.59%   98.60%           
=======================================
  Files         129      129           
  Lines       13852    13877   +25     
=======================================
+ Hits        13658    13683   +25     
  Misses        194      194           
Impacted Files Coverage Δ
featuretools/feature_base/feature_base.py 97.94% <100.00%> (+<0.01%) ⬆️
...retools/tests/primitive_tests/test_feature_base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef2c09...0b0b4ea. Read the comment docs.

@tamargrey tamargrey force-pushed the serialize-multi-output-features branch from 2014ed1 to e4df43e Compare September 9, 2020 18:51
docs/source/changelog.rst Outdated Show resolved Hide resolved
@tamargrey tamargrey force-pushed the serialize-multi-output-features branch from e4df43e to 7676529 Compare September 10, 2020 14:49
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some conflicts with the main branch.

I like the new dictionary tests, let's also test an agg with a where feature, and a groupy transform feature

@tamargrey tamargrey force-pushed the serialize-multi-output-features branch from 85377be to 58ac095 Compare September 11, 2020 19:27
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but out of date with main again

@tamargrey tamargrey force-pushed the serialize-multi-output-features branch from 58ac095 to 0b0b4ea Compare September 14, 2020 17:40
@tamargrey tamargrey merged commit 380c719 into main Sep 14, 2020
@rwedge rwedge deleted the serialize-multi-output-features branch September 21, 2020 19:20
@tuethan1999 tuethan1999 mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants