Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NaturalLanguage Variable Type and deprecate Text #1159

merged 16 commits into from Sep 25, 2020


Copy link

@gsheni gsheni commented Sep 17, 2020

Pull Request Description

Changed in version [python] 3.2: DeprecationWarning is now ignored by default in addition to PendingDeprecationWarning.

  • Renamed all instances of Text to NaturalLanguage in primitives, and documentation
  • Added test to find_variable_types and list_variable_types to make sure Text does not show up.
  • Updated Features Schema 5.0.0 -> 6.0.0
  • Updated Entityset Schema 4.0.0 -> 5.0.0

@gsheni gsheni self-assigned this Sep 17, 2020
@gsheni gsheni requested a review from rwedge September 17, 2020 22:00
featuretools/tests/entityset_tests/ Outdated Show resolved Hide resolved
featuretools/entityset/ Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #1159 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1159   +/-   ##
  Coverage   98.60%   98.60%           
  Files         129      130    +1     
  Lines       13890    13927   +37     
+ Hits        13696    13733   +37     
  Misses        194      194           
Impacted Files Coverage Δ
featuretools/demo/ 94.73% <ø> (ø)
featuretools/tests/entityset_tests/ 100.00% <ø> (ø)
featuretools/tests/entityset_tests/ 100.00% <ø> (ø)
...aturetools/tests/entityset_tests/ 100.00% <ø> (ø)
featuretools/tests/testing_utils/ 100.00% <ø> (ø)
featuretools/entityset/ 96.35% <100.00%> (+0.01%) ⬆️
featuretools/entityset/ 100.00% <100.00%> (ø)
featuretools/feature_base/ 100.00% <100.00%> (ø)
...retools/primitives/standard/ 100.00% <100.00%> (ø)
featuretools/tests/entityset_tests/ 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d6a76...3b18483. Read the comment docs.

docs/source/changelog.rst Outdated Show resolved Hide resolved
rwedge approved these changes Sep 25, 2020
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

rwedge commented Sep 25, 2020

Not sure why the codecov checks aren't showing up but I checked the codecov site and coverage looks good

@gsheni gsheni merged commit 9d58855 into main Sep 25, 2020
1 check passed
@gsheni gsheni deleted the natural_language_type branch September 25, 2020 22:00
@tuethan1999 tuethan1999 mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Rename Text variable type to NaturalLanguage
2 participants