Fix double label column bug by removing duplicate columns before merging #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwedge
reviewed
Sep 21, 2020
docs/source/changelog.rst
Outdated
| @@ -6,13 +6,14 @@ Changelog | |||
| * Enhancements | |||
| * Fixes | |||
| * Allow FeatureOutputSlice features to be serialized (:pr:`1150`) | |||
| * Fix duplicate label column generation when labels are passed in cutoff times and approximate is being used (:pr:`1147`) | |||
There was a problem hiding this comment.
need to update the pr number
Codecov Report
@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 129 129
Lines 13877 13892 +15
=======================================
+ Hits 13683 13698 +15
Misses 194 194
Continue to review full report at Codecov.
|
rwedge
reviewed
Sep 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix double label column bug by removing duplicate columns before merging
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.