New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double label column bug by removing duplicate columns before merging #1160
Conversation
docs/source/changelog.rst
Outdated
@@ -6,13 +6,14 @@ Changelog | |||
* Enhancements | |||
* Fixes | |||
* Allow FeatureOutputSlice features to be serialized (:pr:`1150`) | |||
* Fix duplicate label column generation when labels are passed in cutoff times and approximate is being used (:pr:`1147`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the pr number
Codecov Report
@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 129 129
Lines 13877 13892 +15
=======================================
+ Hits 13683 13698 +15
Misses 194 194
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Once the branch is up to date with main it should be good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Pull Request Description
Fix double label column bug by removing duplicate columns before merging
After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rst
to include this pull request.