Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double label column bug by removing duplicate columns before merging #1160

Merged
merged 3 commits into from Sep 22, 2020

Conversation

tuethan1999
Copy link
Contributor

Pull Request Description

Fix double label column bug by removing duplicate columns before merging


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@tuethan1999 tuethan1999 reopened this Sep 18, 2020
@@ -6,13 +6,14 @@ Changelog
* Enhancements
* Fixes
* Allow FeatureOutputSlice features to be serialized (:pr:`1150`)
* Fix duplicate label column generation when labels are passed in cutoff times and approximate is being used (:pr:`1147`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the pr number

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1160 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         129      129           
  Lines       13877    13892   +15     
=======================================
+ Hits        13683    13698   +15     
  Misses        194      194           
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 99.10% <100.00%> (+<0.01%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.43% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 710503b...ea658c9. Read the comment docs.

Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once the branch is up to date with main it should be good to merge

Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tuethan1999 tuethan1999 merged commit afee3db into main Sep 22, 2020
1 check passed
@tuethan1999 tuethan1999 deleted the iss1160 branch September 22, 2020 23:02
@tuethan1999 tuethan1999 linked an issue Sep 23, 2020 that may be closed by this pull request
@tuethan1999 tuethan1999 mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Label column on approximate cutoff times
2 participants