Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydata sphinx theme #1169

Merged
merged 26 commits into from
Sep 30, 2020
Merged

Pydata sphinx theme #1169

merged 26 commits into from
Sep 30, 2020

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Sep 28, 2020

Updates the docs to use the pydata sphinx theme

https://featuretools.alteryx.com/en/pydata-sphinx-theme/index.html

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1169 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         130      130           
  Lines       13932    13932           
=======================================
  Hits        13738    13738           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941c61b...ac82771. Read the comment docs.

flake8==3.7.8
autopep8==1.4.4
ipython==7.14.0
ipython==7.17.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can further upgrade ipython with the following

ipython==7.16.0; python_version=='3.6'
ipython==7.18.1; python_version>'3.6'

nlp_primitives>=0.3.0
nbsphinx==0.7.1
Sphinx==3.2.1
pydata_sphinx_theme==0.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A higher theme version, if you want

pydata-sphinx-theme==0.4.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@rwedge rwedge requested a review from frances-h September 30, 2020 16:51
Getting Started
---------------

How to start working with Featuretools; The main concepts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a link back to the 5 minute quick start here? Something like:

For a quick introduction to Featuretools, check out our 5 minute quick start guide.

How to start working with Featuretools; the main concepts:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@rwedge rwedge requested a review from frances-h September 30, 2020 19:10
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rwedge rwedge merged commit 05d536c into main Sep 30, 2020
@rwedge rwedge deleted the pydata-sphinx-theme branch September 30, 2020 19:21
@tuethan1999 tuethan1999 mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants