modify ignore_variables docstring #117
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Merging |
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 88.27% 88.33% +0.05%
==========================================
Files 73 73
Lines 7457 7457
==========================================
+ Hits 6583 6587 +4
+ Misses 874 870 -4
Continue to review full report at Codecov.
|
Merged
rwedge
added a commit
that referenced
this pull request
Apr 13, 2018
**v0.1.20** Apr 13, 2018 * Improved chunking when calculating feature matrices (#121) * Primitives as strings in DFS parameters (#129) * Integer time index bugfixes (#128) * Add make_temporal_cutoffs utility function (#126) * Show all entities, switch shape display to row/col (#124) * fixed num characters nan fix (#118) * modify ignore_variables docstring (#117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The value in the
ignore_variabledict takes in a list, not a string. In particular, the loop inDeepFeatureSynthesiswill take the dictionary
ignore_variables = {'hello': 'world'}toself.ignore_variables['hello'] = {'d', 'l', 'o', 'r', 'w'}. This PR updates the docstring to reflect the correct input type.