Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in requirements #1170

Merged
merged 2 commits into from Sep 30, 2020
Merged

Fix typo in requirements #1170

merged 2 commits into from Sep 30, 2020

Conversation

tuethan1999
Copy link
Contributor

Pull Request Description

Fix typo in requirements.txt

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request.

@rwedge
Copy link
Collaborator

rwedge commented Sep 30, 2020

For the release notes entry, let's add this as a second PR associated with the "stop requiring single-threaded dask scheduler" line

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1170 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1170   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         130      130           
  Lines       13932    13932           
=======================================
  Hits        13738    13738           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d536c...3906111. Read the comment docs.

rwedge
rwedge approved these changes Sep 30, 2020
Copy link
Collaborator

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tuethan1999 tuethan1999 merged commit 12bd041 into main Sep 30, 2020
1 check passed
@tuethan1999 tuethan1999 deleted the requirements-typo branch September 30, 2020 21:23
@tuethan1999 tuethan1999 mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants