Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set max koalas version #1192

Merged
merged 3 commits into from Oct 15, 2020
Merged

set max koalas version #1192

merged 3 commits into from Oct 15, 2020

Conversation

rwedge
Copy link
Collaborator

@rwedge rwedge commented Oct 15, 2020

Some tests failing with koalas 1.3.0, temporarily pinning below 1.3.0 while we investigate

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1192 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         130      130           
  Lines       13932    13932           
=======================================
  Hits        13738    13738           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc36f37...950d8e7. Read the comment docs.

* Enhancements
* Fixes
* Changes
* Documentation Changes
* Testing Changes
* Add ``pyspark`` and ``koalas`` to automated dependency checks (:pr:`1192`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an actual change log line. Maybe when we add koalas 1.3.0 support back in, we can delete this log entry and add this pr number to the new log entry.

Copy link
Collaborator

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwedge rwedge merged commit 4fca203 into main Oct 15, 2020
3 checks passed
@rwedge rwedge deleted the pin-koalas-under-1-3-0 branch October 15, 2020 21:37
@jeff-hernandez jeff-hernandez mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants