Skip to content

set max koalas version - #1192

Merged
rwedge merged 3 commits into
mainfrom
pin-koalas-under-1-3-0
Oct 15, 2020
Merged

set max koalas version#1192
rwedge merged 3 commits into
mainfrom
pin-koalas-under-1-3-0

Conversation

@rwedge

@rwedge rwedge commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Some tests failing with koalas 1.3.0, temporarily pinning below 1.3.0 while we investigate

@codecov

codecov Bot commented Oct 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1192 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         130      130           
  Lines       13932    13932           
=======================================
  Hits        13738    13738           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc36f37...950d8e7. Read the comment docs.

Comment thread docs/source/release_notes.rst Outdated
* Changes
* Documentation Changes
* Testing Changes
* Add ``pyspark`` and ``koalas`` to automated dependency checks (:pr:`1192`)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong comment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an actual change log line. Maybe when we add koalas 1.3.0 support back in, we can delete this log entry and add this pr number to the new log entry.

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwedge
rwedge merged commit 4fca203 into main Oct 15, 2020
@rwedge
rwedge deleted the pin-koalas-under-1-3-0 branch October 15, 2020 21:37
@jeff-hernandez jeff-hernandez mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants