Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md with correct badge link #1200

Merged
merged 3 commits into from Oct 26, 2020
Merged

Update README.md with correct badge link #1200

merged 3 commits into from Oct 26, 2020

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Oct 25, 2020

  • Badge link was incorrect, and not working.

@gsheni gsheni self-assigned this Oct 25, 2020
@codecov
Copy link

codecov bot commented Oct 25, 2020 •
edited

Codecov Report

Merging #1200 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         130      130           
  Lines       13932    13932           
=======================================
  Hits        13738    13738           
  Misses        194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c512d...3982202. Read the comment docs.

@gsheni gsheni requested review from tamargrey and rwedge and removed request for tamargrey October 25, 2020 20:40
rwedge
rwedge approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit a7d7f56 into main Oct 26, 2020
@jeff-hernandez jeff-hernandez mentioned this pull request Oct 30, 2020
Merged
@gsheni gsheni deleted the fix_badge_link branch January 25, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsheni @rwedge