English sentence feature descriptions#1201
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
+ Coverage 98.60% 98.63% +0.02%
==========================================
Files 130 134 +4
Lines 13932 14284 +352
==========================================
+ Hits 13738 14089 +351
- Misses 194 195 +1
Continue to review full report at Codecov.
|
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Looking good to me - I will take another look tomorrow and dive a little deeper into the logic, and leave any additional comments then.
thehomebrewnerd
left a comment
There was a problem hiding this comment.
Just a few more suggestions for consideration. I don't think any of these are blocking issues though, and overall this looks good!
rwedge
left a comment
There was a problem hiding this comment.
I think it'd be good to add some examples of how to use this functionality to the docs.
Perhaps a brief example, similar to what we did with feature graphs, along with a guide entry about how the user can customize the descriptions?
Add
describe_featurefunction which takes a feature and optionally custom, manually defined metadata and returns an English sentence description of what the feature is:<Feature: value>: The "value".<Feature: ABSOLUTE(value)>: The absolute value of the "value".<Feature: sessions.device_name>: The "device_name" for the instance of "sessions" associated with this instance of "log".<Feature: MODE(log.zipcode)>: The most frequently occurring value of the "zipcode" of all instances of "log" for each "id" in "customers".Resolves #940