Update last time index code to fix Koalas error #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1202 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 130 130
Lines 13932 13932
=======================================
Hits 13738 13738
Misses 194 194
Continue to review full report at Codecov.
|
rwedge
reviewed
Oct 27, 2020
docs/source/release_notes.rst
Outdated
| @@ -5,6 +5,7 @@ Release Notes | |||
| **Future Release** | |||
| * Enhancements | |||
| * Fixes | |||
| * Update ``EntitySet.add_last_time_indexes`` to work with Koalas 1.3.0 (:pr:`1202`) | |||
There was a problem hiding this comment.
Can we remove the "Restrict koalas version" entry in the release notes and and add its PR number to this entry?
rwedge
reviewed
Oct 27, 2020
added 2 commits
October 27, 2020 15:04
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update add last time index code to fix Koalas error
When Koalas 1.3.0 was released a new error occurred when setting last time indexes as a result. This PR implements changes to fix this error. The updated code was tested with Koalas 1.1.0, 1.2.0 and 1.3.0 and works fine for each. As a result, the upper version restriction on Koalas in
koalas-requirements.txtwas also removed.