Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerhub Credentials to CI #1204

Merged
merged 8 commits into from Oct 28, 2020
Merged

Add Dockerhub Credentials to CI #1204

merged 8 commits into from Oct 28, 2020

Conversation

gsheni
Copy link
Member

@gsheni gsheni commented Oct 28, 2020 •
edited

  • CI before authentication

Screen Shot 2020-10-28 at 12 28 11 PM

  • CI after authentication:

Screen Shot 2020-10-28 at 12 31 33 PM

@gsheni gsheni self-assigned this Oct 28, 2020
@gsheni gsheni requested a review from rwedge October 28, 2020 16:33
@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited

Codecov Report

Merging #1204 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         130      130           
  Lines       13932    13932           
=======================================
  Hits        13738    13738           
  Misses        194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745954e...d4b27d8. Read the comment docs.

rwedge
rwedge previously approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gsheni
Copy link
Member Author

gsheni commented Oct 28, 2020

After using CircleCI context for credentials
Screen Shot 2020-10-28 at 1 54 07 PM

@gsheni gsheni requested a review from rwedge October 28, 2020 17:54
rwedge
rwedge reviewed Oct 28, 2020
View reviewed changes
.circleci/config.yml Outdated
- run_premium_primitives_tests_on_release:
name: "run premium primitives tests on release"
filters:
branches:
ignore: /.*/
tags:
only: /^v\d+\.\d+\.\d+$/
context:
- dockerhub
Copy link
Contributor

@rwedge rwedge Oct 28, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can write this as context: dockerhub on a single line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

rwedge
rwedge approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gsheni gsheni merged commit f6f5221 into main Oct 28, 2020
@gsheni gsheni deleted the update_ci_credentials branch October 28, 2020 18:32
@dsherry dsherry mentioned this pull request Oct 28, 2020
Merged
@jeff-hernandez jeff-hernandez mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsheni @rwedge