Skip to content

Add Dockerhub Credentials to CI - #1204

Merged
gsheni merged 8 commits into
mainfrom
update_ci_credentials
Oct 28, 2020
Merged

Add Dockerhub Credentials to CI#1204
gsheni merged 8 commits into
mainfrom
update_ci_credentials

Conversation

@gsheni

@gsheni gsheni commented Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • CI before authentication

Screen Shot 2020-10-28 at 12 28 11 PM

  • CI after authentication:

Screen Shot 2020-10-28 at 12 31 33 PM

@gsheni gsheni self-assigned this Oct 28, 2020
@gsheni
gsheni requested a review from rwedge October 28, 2020 16:33
@codecov

codecov Bot commented Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1204 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files         130      130           
  Lines       13932    13932           
=======================================
  Hits        13738    13738           
  Misses        194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745954e...d4b27d8. Read the comment docs.

rwedge
rwedge previously approved these changes Oct 28, 2020
View reviewed changes

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gsheni

gsheni commented Oct 28, 2020

Copy link
Copy Markdown
Contributor Author

After using CircleCI context for credentials
Screen Shot 2020-10-28 at 1 54 07 PM

@gsheni
gsheni requested a review from rwedge October 28, 2020 17:54
rwedge
rwedge reviewed Oct 28, 2020
View reviewed changes
Comment thread .circleci/config.yml Outdated
tags:
only: /^v\d+\.\d+\.\d+$/
context:
- dockerhub

@rwedge rwedge Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can write this as context: dockerhub on a single line

@gsheni gsheni Oct 28, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

rwedge
rwedge approved these changes Oct 28, 2020
View reviewed changes

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gsheni
gsheni merged commit f6f5221 into main Oct 28, 2020
@gsheni
gsheni deleted the update_ci_credentials branch October 28, 2020 18:32
@dsherry dsherry mentioned this pull request Oct 28, 2020
Merged
@jeff-hernandez jeff-hernandez mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rwedge rwedge rwedge approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gsheni gsheni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gsheni @rwedge