Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature descriptions to feature graphs #1212

Merged
merged 4 commits into from
Nov 2, 2020
Merged

Conversation

frances-h
Copy link
Contributor

Add ability to add a description of the feature to the feature's graph as a graph caption. A description can either be manually passed in, or graph_feature can automatically generate a description with ft.describe_feature:

graph_description

@frances-h frances-h self-assigned this Nov 2, 2020
@frances-h frances-h requested a review from rwedge November 2, 2020 17:47
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1212 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files         134      134           
  Lines       14309    14337   +28     
=======================================
+ Hits        14114    14142   +28     
  Misses        195      195           
Impacted Files Coverage Δ
featuretools/feature_base/feature_visualizer.py 98.61% <100.00%> (+0.04%) ⬆️
...s/tests/primitive_tests/test_feature_visualizer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa44c65...56e222e. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frances-h frances-h merged commit 2629470 into main Nov 2, 2020
@frances-h frances-h deleted the graph-descriptions branch November 2, 2020 21:38
@rwedge rwedge mentioned this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants