Update PR url in release notes check-in test #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gsheni
reviewed
Nov 11, 2020
| @@ -271,7 +271,7 @@ jobs: | |||
| password: $DOCKERHUB_PASSWORD | |||
| steps: | |||
| - checkout | |||
| - run: cat docs/source/release_notes.rst | grep ":pr:\`${CIRCLE_PULL_REQUEST##https://github.com/FeatureLabs/featuretools/pull/}\`" | |||
| - run: cat docs/source/release_notes.rst | grep ":pr:\`${CIRCLE_PULL_REQUEST##https://github.com/alteryx/featuretools/pull/}\`" | |||
There was a problem hiding this comment.
Not sure if you want to fix other instances of this as well:
There was a problem hiding this comment.
I'll make an issue for it, we can do a separate PR
gsheni
approved these changes
Nov 11, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the url so that the check for users updating the release notes works with the new org
Also sets a specific version range for urllib3 to deal with conflicting requirements from other dependencies
Not sure why the ci checks are on the job level now