Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
- Coverage 98.63% 98.34% -0.30%
==========================================
Files 134 134
Lines 14337 14419 +82
==========================================
+ Hits 14142 14180 +38
- Misses 195 239 +44
Continue to review full report at Codecov.
|
rwedge
reviewed
Nov 19, 2020
Contributor
|
Should this PR also remove the circleci config files? |
Contributor
Author
I think it'd be easier to update the branch protection rules by removing circleci in a separate PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration tests will be added as a GitHub Action. We'll need to add secrets in the repository settings for
PP_Kto run premium primitive tests.