Skip to content

Migrate Integration Tests#1226

Merged
jeff-hernandez merged 55 commits intomainfrom
migrate_integration_tests
Nov 20, 2020
Merged

Migrate Integration Tests#1226
jeff-hernandez merged 55 commits intomainfrom
migrate_integration_tests

Conversation

@jeff-hernandez
Copy link
Contributor

@jeff-hernandez jeff-hernandez commented Nov 13, 2020

The integration tests will be added as a GitHub Action. We'll need to add secrets in the repository settings for PP_K to run premium primitive tests.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #1226 (bd8730f) into main (78cf986) will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
- Coverage   98.63%   98.34%   -0.30%     
==========================================
  Files         134      134              
  Lines       14337    14419      +82     
==========================================
+ Hits        14142    14180      +38     
- Misses        195      239      +44     
Impacted Files Coverage Δ
featuretools/entityset/relationship.py 94.18% <0.00%> (-4.54%) ⬇️
featuretools/primitives/base/primitive_base.py 96.34% <0.00%> (-3.66%) ⬇️
featuretools/tests/conftest.py 96.61% <0.00%> (-3.39%) ⬇️
featuretools/synthesis/encode_features.py 93.75% <0.00%> (-2.31%) ⬇️
featuretools/entityset/entity.py 94.33% <0.00%> (-2.02%) ⬇️
...eaturetools/tests/entityset_tests/test_plotting.py 98.36% <0.00%> (-1.64%) ⬇️
featuretools/tests/entityset_tests/test_es.py 98.81% <0.00%> (-1.19%) ⬇️
featuretools/demo/flight.py 94.93% <0.00%> (-1.17%) ⬇️
featuretools/feature_base/feature_base.py 97.28% <0.00%> (-0.66%) ⬇️
...uretools/tests/entityset_tests/test_es_metadata.py 99.40% <0.00%> (-0.60%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78cf986...bd8730f. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge commented Nov 19, 2020

Should this PR also remove the circleci config files?

@jeff-hernandez
Copy link
Contributor Author

Should this PR also remove the circleci config files?

I think it'd be easier to update the branch protection rules by removing circleci in a separate PR.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeff-hernandez jeff-hernandez merged commit f7fc4ab into main Nov 20, 2020
@jeff-hernandez jeff-hernandez deleted the migrate_integration_tests branch November 20, 2020 21:29
@rwedge rwedge mentioned this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants