Skip to content

Add support for local tar file in read_entityset#1228

Merged
gsheni merged 16 commits intomainfrom
read_entityset_local_tar
Nov 23, 2020
Merged

Add support for local tar file in read_entityset#1228
gsheni merged 16 commits intomainfrom
read_entityset_local_tar

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Nov 14, 2020

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 14, 2020

CLA assistant check
All committers have signed the CLA.

@gsheni gsheni self-assigned this Nov 14, 2020
@gsheni gsheni requested a review from rwedge November 14, 2020 00:14
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2020

Codecov Report

Merging #1228 (381fb5b) into main (b6d916f) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
+ Coverage   98.34%   98.64%   +0.29%     
==========================================
  Files         134      134              
  Lines       14419    14348      -71     
==========================================
- Hits        14180    14153      -27     
+ Misses        239      195      -44     
Impacted Files Coverage Δ
featuretools/entityset/deserialize.py 100.00% <100.00%> (ø)
...etools/tests/entityset_tests/test_serialization.py 99.63% <100.00%> (+0.01%) ⬆️
featuretools/utils/wrangle.py 76.00% <100.00%> (+0.74%) ⬆️
featuretools/__main__.py 42.30% <0.00%> (-0.55%) ⬇️
...computational_backends/calculate_feature_matrix.py 99.10% <0.00%> (-0.01%) ⬇️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.28% <0.00%> (+0.14%) ⬆️
featuretools/entityset/entityset.py 97.76% <0.00%> (+0.17%) ⬆️
...mputational_backend/test_feature_set_calculator.py 100.00% <0.00%> (+0.36%) ⬆️
featuretools/tests/synthesis/test_dfs_method.py 100.00% <0.00%> (+0.44%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 97.91% <0.00%> (+0.44%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d916f...381fb5b. Read the comment docs.

Comment thread featuretools/utils/wrangle.py Outdated
@gsheni gsheni requested review from tuethan1999 and removed request for rwedge November 23, 2020 17:39
Copy link
Copy Markdown
Contributor

@tuethan1999 tuethan1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gsheni gsheni merged commit 1a9fa80 into main Nov 23, 2020
@gsheni gsheni deleted the read_entityset_local_tar branch November 23, 2020 18:17
@rwedge rwedge mentioned this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entityset deserialization does not support local tar file

4 participants