Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move handle_time to entityset #1276

merged 5 commits into from Dec 15, 2020

Move handle_time to entityset #1276

merged 5 commits into from Dec 15, 2020


Copy link

Move _handle_time from Entity to EntitySet

Closes #1275

Moves the _handle_time method from Entity to EntitySet in preparation for Woodwork integration.

@thehomebrewnerd thehomebrewnerd self-assigned this Dec 11, 2020
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1276 (c9bc59f) into main (8e82989) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1276   +/-   ##
  Coverage   98.35%   98.35%           
  Files         134      134           
  Lines       14439    14440    +1     
+ Hits        14202    14203    +1     
  Misses        237      237           
Impacted Files Coverage Δ
...computational_backends/ 99.10% <100.00%> (ø)
featuretools/entityset/ 93.49% <100.00%> (-0.77%) ⬇️
featuretools/entityset/ 97.95% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e82989...c9bc59f. Read the comment docs.

Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thehomebrewnerd thehomebrewnerd merged commit 2b11e78 into main Dec 15, 2020
1 check passed
@thehomebrewnerd thehomebrewnerd deleted the move-handle-time branch December 15, 2020 20:39
@rwedge rwedge mentioned this pull request Dec 31, 2020
@alteryx alteryx deleted a comment from wuxinshui Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Move _handle_time from Entity to EntitySet
3 participants