Skip to content

Fix install command for add-ons#1279

Merged
gsheni merged 3 commits into
mainfrom
fix_install_documentation
Dec 16, 2020
Merged

Fix install command for add-ons#1279
gsheni merged 3 commits into
mainfrom
fix_install_documentation

Conversation

@gsheni

@gsheni gsheni commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

@gsheni
gsheni requested a review from rwedge December 15, 2020 23:09
@gsheni gsheni self-assigned this Dec 15, 2020
@gsheni
gsheni force-pushed the fix_install_documentation branch from 43416eb to da3e2fc Compare December 15, 2020 23:11
Comment thread docs/source/install.rst
You can install add-ons individually or all at once by running::

python -m pip install featuretools[complete]
python -m pip install "featuretools[complete]"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for the quotes is because some shells (like zsh) use square brackets for pattern matching while other shells (like bash) don't. Adding quotes makes it work for all shells.

@codecov

codecov Bot commented Dec 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1279 (da3e2fc) into main (3e59aa6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         134      134           
  Lines       14456    14456           
=======================================
  Hits        14220    14220           
  Misses        236      236           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e59aa6...da3e2fc. Read the comment docs.

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gsheni
gsheni merged commit 6b51aae into main Dec 16, 2020
@rwedge rwedge mentioned this pull request Dec 31, 2020
@gsheni
gsheni deleted the fix_install_documentation branch January 25, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Install documentation

2 participants