Fix install command for add-ons #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gsheni
commented
Dec 15, 2020
•
gsheni
commented
- Fixes Update Install documentation #1198
- Proof:
gsheni
force-pushed
the
fix_install_documentation
branch
from
43416eb to
da3e2fc
Compare
gsheni
commented
Dec 15, 2020
| @@ -16,44 +16,44 @@ Add-ons | |||
| -------- | |||
| You can install add-ons individually or all at once by running:: | |||
|
|
|||
| python -m pip install featuretools[complete] | |||
| python -m pip install "featuretools[complete]" | |||
There was a problem hiding this comment.
The reason for the quotes is because some shells (like zsh) use square brackets for pattern matching while other shells (like bash) don't. Adding quotes makes it work for all shells.
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 134 134
Lines 14456 14456
=======================================
Hits 14220 14220
Misses 236 236 Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.